Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Local Lando config for OCP and suggest Secrets for license storage #9327

Merged
merged 15 commits into from
Dec 11, 2024

Conversation

jazzsequence
Copy link
Contributor

@jazzsequence jazzsequence commented Nov 22, 2024

Summary

Enable Object Cache Pro for WordPress - Updates Lando configuration to configure OCP locally for Lando (alternative to #9309 which recommends disabling OCP). Additionally, this PR suggests using Pantheon Secrets for storing the license key for Composer-based installs.

@jazzsequence jazzsequence requested a review from a team as a code owner November 22, 2024 21:24
which won't exist in non-pantheon environments
@jazzsequence jazzsequence self-assigned this Nov 22, 2024
@jazzsequence jazzsequence requested a review from pwtyler November 22, 2024 21:28
@jazzsequence jazzsequence added Type: Fix Content Issue or PR to resolve incorrect information in the docs Topic: WordPress WordPress-specific Topic: Caching Caching related issues at the CDN or CMS level labels Nov 22, 2024
Copy link
Contributor

@stevector stevector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems odd that we're recommending committing the license to git. That shouldn't be necessary with Secrets Manager.

@jazzsequence
Copy link
Contributor Author

Removed recommendation to use Secrets. Reworked some other bits and pieces and also removed the recommendation to commit the auth.json file to the git repository (and added notes about how you need it if you're going to update the plugin locally with composer).

@pwtyler @stevector would appreciate you both taking another look

@@ -295,7 +291,55 @@ Refer to the [official Object Cache Pro documentation](https://objectcache.pro/d

- If you are using WordPress Multisite, subsites do not get their own configuration or graphs. Navigate to `/wp-admin/network/settings.php?page=objectcache` to view network-wide configuration and graphs. This is the only screen throughout the network that displays this information.

### Additional Considerations
## Local configuration with Lando
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jazzsequence did you do all these steps yourself? If not, one of us should do them on our machines to confirm accuracy. If you did, I'll mark the PR as approved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but I can check the redis config in the lando.yml one more time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. I have cache set locally. that's actually optional and only really changes the version of redis being used (because I believe the lando recipe is the older version that we serve) but either work with OCP. i updated the docs to note this.

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9327-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

not required for OCP to function, just if you want to use a redis version that more closely matches Pantheon's environment
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9327-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9327-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link
Contributor

@stevector stevector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates!

@stevector stevector merged commit 291eb0d into main Dec 11, 2024
12 checks passed
@stevector stevector deleted the 9309-lando-config-for-ocp branch December 11, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Caching Caching related issues at the CDN or CMS level Topic: WordPress WordPress-specific Type: Fix Content Issue or PR to resolve incorrect information in the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants