-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Local Lando config for OCP and suggest Secrets for license storage #9327
Conversation
but provide a manual step for doing it the old way
which won't exist in non-pantheon environments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems odd that we're recommending committing the license to git. That shouldn't be necessary with Secrets Manager.
auth.json is only needed for local development
Removed recommendation to use Secrets. Reworked some other bits and pieces and also removed the recommendation to commit the @pwtyler @stevector would appreciate you both taking another look |
@@ -295,7 +291,55 @@ Refer to the [official Object Cache Pro documentation](https://objectcache.pro/d | |||
|
|||
- If you are using WordPress Multisite, subsites do not get their own configuration or graphs. Navigate to `/wp-admin/network/settings.php?page=objectcache` to view network-wide configuration and graphs. This is the only screen throughout the network that displays this information. | |||
|
|||
### Additional Considerations | |||
## Local configuration with Lando |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jazzsequence did you do all these steps yourself? If not, one of us should do them on our machines to confirm accuracy. If you did, I'll mark the PR as approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but I can check the redis config in the lando.yml one more time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated. I have cache
set locally. that's actually optional and only really changes the version of redis being used (because I believe the lando recipe is the older version that we serve) but either work with OCP. i updated the docs to note this.
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9327-documentation.appa.pantheon.site |
not required for OCP to function, just if you want to use a redis version that more closely matches Pantheon's environment
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9327-documentation.appa.pantheon.site |
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9327-documentation.appa.pantheon.site |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates!
Summary
Enable Object Cache Pro for WordPress - Updates Lando configuration to configure OCP locally for Lando (alternative to #9309 which recommends disabling OCP). Additionally, this PR suggests using Pantheon Secrets for storing the license key for Composer-based installs.