-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Local Lando config for OCP and suggest Secrets for license storage #9327
Merged
+104
−48
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
dd002dd
Add local config with Lando suggestions
jazzsequence 58ff682
use one-liner to store license directly to auth.json
jazzsequence 619392d
suggest secrets for storing OCP license
jazzsequence 31c0d68
add proper checking for `pantheon_get_secret`
jazzsequence 7e596bc
add additional lando note about sslverify settings
jazzsequence 963b29f
copy edits for composer-based install
jazzsequence bcc9463
remove instruction to git commit & add alert
jazzsequence da77b59
don't recommend copying and pasting the license
jazzsequence 00a49d5
specify repositories section
jazzsequence 0d66210
update outdated copy
jazzsequence c5f416e
remove tablist and secrets recommendation
jazzsequence 7e74d0b
use $token when we talk about local config
jazzsequence 474839a
link to ocp docs site
jazzsequence 9772842
service name should be 'cache'
jazzsequence f2b83f1
note that the redis config is optional
jazzsequence File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jazzsequence did you do all these steps yourself? If not, one of us should do them on our machines to confirm accuracy. If you did, I'll mark the PR as approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but I can check the redis config in the lando.yml one more time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated. I have
cache
set locally. that's actually optional and only really changes the version of redis being used (because I believe the lando recipe is the older version that we serve) but either work with OCP. i updated the docs to note this.