Update 3x.yml #2653
Update 3x.yml #2653
Conversation
.github/workflows/3x.yml
Outdated
| @@ -58,7 +58,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| operating-system: [ 'macos-latest' ] | |||
| php-versions: [ '7.4', '8.2', '8.3' ] | |||
| php-versions: [ '7.4', '8.3', '8.4' ] | |||
There was a problem hiding this comment.
We still support/recommend PHP 8.2... Should we continue to test against that and just add 8.4 instead?
There was a problem hiding this comment.
PHP Terminus supports != PHP platform supports.
If we're not going to test all supported versions of PHP, go with lowest and highest (8.1 and 8.4), otherwise matrix all of them.
There was a problem hiding this comment.
Yeah I don't think that Terminus needs to test against every PHP version, just a representative sample should be fine. I'd recommend 7.4, 8.1 (or whatever the lowest php version that is still supported) and 8.4 (or the highest version of php supported by Terminus).
There was a problem hiding this comment.
Makes sense. Switched to 8.0 and 8.4
FWIW; this PR is only to try to surface the existing errors
| @@ -58,7 +58,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| operating-system: [ 'macos-latest' ] | |||
| php-versions: [ '7.4', '8.2', '8.3' ] | |||
| php-versions: [ '7.4', '8.0', '8.4' ] | |||
There was a problem hiding this comment.
| php-versions: [ '7.4', '8.0', '8.4' ] | |
| php-versions: [ '7.4', '8.1', '8.4' ] |
8.0 is EoL
| @@ -76,6 +76,7 @@ jobs: | |||
| TERMINUS_VERIFY_HOST_CERT: ${{ vars.TERMINUS_VERIFY_HOST_CERT }} | |||
| HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: 1 | |||
| HOMBEBREW_NO_AUTO_UPDATE: 1 | |||
| TERMINUS_ALLOW_UNSUPPORTED_NEWER_PHP: 1 | |||
There was a problem hiding this comment.
Don't set this in CI, update wherever those supported values are set.
There was a problem hiding this comment.
My intention was just to surface errors in this PR to address them later. But I've failed to do so 😂 I guess we will wait until we actually prioritize a ticket to provide this support :)
No description provided.