Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3x.yml #2653

Draft
wants to merge 10 commits into
base: 3.x
Choose a base branch
from
+861 −883
Draft

Update 3x.yml #2653

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
17fb64f
Update 3x.yml
kporras07 Dec 6, 2024
e8ba7df
8.0 and 8.4.
kporras07 Dec 6, 2024
d967cc5
Variable in phpunit.
kporras07 Dec 6, 2024
c3413b4
[DEVX-3831] PHP 8.4 Compatibility; removes support for PHP 8.1 and ea…
greg-1-anderson Dec 16, 2024
6687c21
Set Terminus version to 4.0.0-dev and start a CHANGELOG
greg-1-anderson Dec 16, 2024
353cb73
Check for attempts at using old versions of PHP, and fail fast with a…
greg-1-anderson Dec 16, 2024
17ba55a
Merge branch '3.x' of github.com:pantheon-systems/terminus into php-8…
kporras07 Jan 17, 2025
516135f
Force terminus allow unsupported versions.
kporras07 Jan 17, 2025
f399a59
Temporarily only test in 8.4.
kporras07 Jan 17, 2025
500acc4
Merge branch '4.x' of github.com:pantheon-systems/terminus into php-8…
kporras07 Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/3x.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
strategy:
matrix:
operating-system: [ 'macos-latest' ]
php-versions: [ '7.4', '8.2', '8.3' ]
php-versions: [ '7.4', '8.3', '8.4' ]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still support/recommend PHP 8.2... Should we continue to test against that and just add 8.4 instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP Terminus supports != PHP platform supports.

If we're not going to test all supported versions of PHP, go with lowest and highest (8.1 and 8.4), otherwise matrix all of them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't think that Terminus needs to test against every PHP version, just a representative sample should be fine. I'd recommend 7.4, 8.1 (or whatever the lowest php version that is still supported) and 8.4 (or the highest version of php supported by Terminus).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Switched to 8.0 and 8.4

FWIW; this PR is only to try to surface the existing errors

max-parallel: 1
env:
TERMINUS_TOKEN: ${{ secrets.TERMINUS_TOKEN }}
Expand Down
Loading