Improve crash reporting integration #9892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the following changes to error monitoring integration: * Tracing is set-up for every build not just v3 builds. This is so we can get visibility on the mainline rust code. This is disabled by default. * Tracing/Sentry code are moved to a new crate * Crash reporting integration is added with `minidumper`, to allow us to get more information about crashes.
| [`minidumper`](https://github.com/EmbarkStudios/crash-handling/tree/main/minidumper) library. The server should write | ||
| and report the crash. | ||
|
|
||
| A default server implementation is not provided, but an example can be seen on `examples/sample_usage.rs`. |
There was a problem hiding this comment.
Can it be run? Instructions?
There was a problem hiding this comment.
Yes it can be ran with cargo run --example sample_usage ;
MonicaOlejniczak
approved these changes
Aug 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these changes are specific to canary builds and opt-in. They're meant to track internal reliability of parcel at Atlassian
We lack visibility on native crashes coming from parcel, but reports of crashes are frequent.
This commit makes the following changes to error monitoring integration:
minidumper, to allow us to get more information about crashes.minidumperis picked rather than thesentry-nativeSDK because providing the SDK for all supported parcel architectures is not something we'd like to maintain.Previously written Rust / build wrappers for that SDK (which is a C dependency) have been deprecated in favour of this approach. https://github.com/daxpedda/sentry-contrib-native.