Support mono builds for rtk platforms and modify platform names #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkbroc
reviewed
May 14, 2024
| @@ -73,7 +73,7 @@ describe('Utilities', () => { | |||
| 26: 'Asset Tracker / Monitor One', | |||
| 28: 'Tracker M', | |||
| 32: 'Photon 2 / P2', | |||
| 35: 'M SoM' | |||
| 35: 'M-SoM' | |||
There was a problem hiding this comment.
Wow, I was sure that platform names had been updated in device-constants back in March to have dashes but that's not the case. See https://s.slack.com/archives/C64D4D78D/p1710540307492059?thread_ts=1710164487.645659&cid=C64D4D78D for the right names:
- E-SoM-X
- A-SoM
- B-SoM
- X-SoM
- B5-SoM
- Tracker-M
Can you update device-constants with those names please?
monkbroc
approved these changes
May 14, 2024
keeramis
force-pushed
the
chore/update-device-constants-and-platform-name
branch
from
7691dbf to
4f1ca3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title says.
Related Issues / Discussions
https://github.com/particle-iot-inc/device-constants/pull/38
Completeness