Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mono builds for rtk platforms and modify platform names #734

Merged
merged 3 commits into from
May 15, 2024
Merged

Support mono builds for rtk platforms and modify platform names #734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ba9b88
Update device constants and platform name
keeramis May 14, 2024
c7b98e7
Update device-constants
keeramis May 14, 2024
4f1ca3c
Update display names for platforms
keeramis May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions npm-shrinkwrap.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
}
],
"dependencies": {
"@particle/device-constants": "^3.3.0",
"@particle/device-constants": "^3.4.0",
"binary-version-reader": "^2.3.1",
"chalk": "^2.4.2",
"cli-progress": "^3.12.0",
Expand Down
6 changes: 3 additions & 3 deletions src/lib/flash-helper.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ describe('flash-helper', () => {
expect(mode).to.deep.equal({ flashMode: 'NORMAL', platformId: 26 });
});

it ('returns an error for mono builds', async() => {
it ('supports mono builds on rtk platforms', async() => {
const p2PlatformId = 32;
const file = await createBinary(ModuleInfo.FunctionType.MONO_FIRMWARE, p2PlatformId);
let error;
Expand All @@ -588,8 +588,8 @@ describe('flash-helper', () => {
} catch (e) {
error = e;
}
expect(error).to.be.an.instanceOf(Error);
expect(error).to.have.property('message', 'Module type monoFirmware unsupported for p2');

expect(error).to.be.undefined;
});
});

Expand Down
10 changes: 5 additions & 5 deletions src/lib/utilities.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ describe('Utilities', () => {
12: 'Argon',
13: 'Boron',
14: 'Xenon',
15: 'E SoM X',
23: 'B SoM',
25: 'B5 SoM',
15: 'E-SoM-X',
23: 'B-SoM',
25: 'B5-SoM',
26: 'Asset Tracker / Monitor One',
28: 'Tracker M',
28: 'Tracker-M',
32: 'Photon 2 / P2',
35: 'M SoM'
35: 'M-SoM'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I was sure that platform names had been updated in device-constants back in March to have dashes but that's not the case. See https://s.slack.com/archives/C64D4D78D/p1710540307492059?thread_ts=1710164487.645659&cid=C64D4D78D for the right names:

  • E-SoM-X
  • A-SoM
  • B-SoM
  • X-SoM
  • B5-SoM
  • Tracker-M

Can you update device-constants with those names please?

});
});
});
Expand Down
Loading