Ntpv5 packet parsing #1125
Closed
Ntpv5 packet parsing #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1125 +/- ##
==========================================
- Coverage 85.33% 85.06% -0.28%
==========================================
Files 54 57 +3
Lines 14740 15437 +697
==========================================
+ Hits 12579 13132 +553
- Misses 2161 2305 +144
☔ View full report in Codecov by Sentry. |
This ensures that all tests are run with and without the new feature, and clippy detects any warnings also in the new code.
tdittr
commented
Oct 10, 2023
tdittr
commented
Oct 10, 2023
This reduced clutter of `cfg(feature)` in NTPv4 modules.
folkertdev
reviewed
Oct 17, 2023
|
Replaced by rebased version in #1141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.