Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ntpv5 packet parsing rebased #1141

Merged
merged 28 commits into from
Oct 18, 2023
Merged

Ntpv5 packet parsing rebased #1141

merged 28 commits into from
Oct 18, 2023

Conversation

tdittr
Copy link
Contributor

@tdittr tdittr commented Oct 18, 2023

Rebased version of #1125

tdittr and others added 27 commits October 18, 2023 08:52
@tdittr
Start implementation of NTPv5 header parsing
de62173
@marlonbaeten @tdittr
Implemented v5 header parsing
2b4dd00
@tdittr
Implement parsing and serialization for draft identification extension
4a16d5f
@tdittr
Add NTPv5 header to general NtpHeader to prepare for usage in server
b6bea9d
@tdittr
Add NTPv5 feature to CI and fuzzing
0a92d79 
This ensures that all tests are run with and without the new feature,
and clippy detects any warnings also in the new code.
@tdittr
Address clippy warnings
36a8201
@marlonbaeten @tdittr
Implement v5 header serialization
b5a5591
@marlonbaeten @tdittr
Remove panic from v5 header parsing
c98c43f
@marlonbaeten @tdittr
Fix clippy warnings in v5.rs
906584f
@tdittr
Add extension field ids for all draft extensions
c0c9b7d
@tdittr
Address PR comment and simplify draft id deserialization
19e5577
@tdittr
Address PR comment, fix typo, add comments
e7d2c66
@marlonbaeten @tdittr
Move v5 module to subdirectory
f9266f2
@tdittr
Handle V5 extension fields
fa96939
@tdittr
Undo change that violated MSRV
ca4ccc2
@tdittr
Move NTPv5 errors in seperate enum
ac6682c 
This reduced clutter of `cfg(feature)` in NTPv4 modules.
@tdittr
Switch flags from using hex to binary for better readability
c7fe228
@marlonbaeten @tdittr
Encode correct length in v5 extension fields
d920434
@marlonbaeten @tdittr
Include ExtensionHeaderVersion in fuzzer call
9f24396
@tdittr
Implement missing setters and getters for v5 header
a2cd777
@marlonbaeten @tdittr
Fix fuzzer for versioned extension headers
aa5fa41
@marlonbaeten @tdittr
Fix lock file
a680093
@marlonbaeten @tdittr
Update versions in fuzz/Cargo.lock
f18e752
@marlonbaeten @tdittr
Format fuzzer code
95fbaf5
@tdittr
Also run fuzzer smoke tests for ntpv5
a38e6c6
@marlonbaeten @tdittr
We have derive_arbitrary at home
a433e6a
@tdittr
Address review comments
665facc
@tdittr tdittr requested a review from folkertdev October 18, 2023 06:58
@tdittr tdittr mentioned this pull request Oct 18, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Attention: 143 lines in your changes are missing coverage. Please review.

Comparison is base (0dafaf9) 85.33% compared to head (01399e1) 85.06%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1141      +/-   ##
==========================================
- Coverage   85.33%   85.06%   -0.28%     
==========================================
  Files          54       57       +3     
  Lines       14740    15437     +697     
==========================================
+ Hits        12579    13132     +553     
- Misses       2161     2305     +144
Files Coverage Δ
ntp-proto/src/lib.rs 100.00% <ø> (ø)
ntp-proto/src/packet/crypto.rs 90.37% <ø> (ø)
ntp-proto/src/packet/v5/extension_fields.rs 100.00% <100.00%> (ø)
ntp-proto/src/packet/error.rs 41.17% <33.33%> (-0.76%) ⬇️
ntp-proto/src/packet/extension_fields.rs 93.54% <96.37%> (ø)
ntp-proto/src/packet/v5/error.rs 21.42% <21.42%> (ø)
ntp-proto/src/packet/v5/mod.rs 89.14% <89.14%> (ø)
ntp-proto/src/packet/mod.rs 84.18% <24.32%> (-4.80%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

folkertdev
folkertdev approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ntpv5 let's go

@folkertdev folkertdev merged commit 5c2bff6 into main Oct 18, 2023
22 checks passed
@folkertdev folkertdev deleted the ntpv5-packet-parsing-rebased branch October 18, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@folkertdev folkertdev folkertdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
All NTPv5 Draft Features Implemented
Development

Successfully merging this pull request may close these issues.
3 participants
@tdittr @folkertdev @marlonbaeten