Refactor serve_packet into IO and non IO parts #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes redundancy by moving out all serialization and IO from the match arms and only do them once.
This makes testing and reading easier.
This decouples the counters from the response generation, making for better readable code.
This reduces the methods in server, since stat counting only really needs the stats and the result and none of the other fields of Server.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1151 +/- ##
==========================================
+ Coverage 85.06% 85.25% +0.18%
==========================================
Files 57 57
Lines 15437 15506 +69
==========================================
+ Hits 13132 13219 +87
+ Misses 2305 2287 -18
☔ View full report in Codecov by Sentry. |
folkertdev
force-pushed
the
serve-packet-refactor
branch
from
89312cc to
cf5a6f9
Compare
davidv1992
reviewed
Oct 25, 2023
This ensures we can not even create a response that was longer than the original request.
tdittr
changed the title
davidv1992
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples the IO during packet handling from the actual logic. This allows easier writing of tests,
This PR also flattens a lot of nested matches to make them more readable.