Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor serve_packet into IO and non IO parts #1151

Merged
merged 25 commits into from
Oct 26, 2023
+402 −294
Merged

Refactor serve_packet into IO and non IO parts #1151

Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
c23c266
refactor serve_packet
folkertdev Oct 18, 2023
aaed878
refactor how filters are applied
folkertdev Oct 18, 2023
a845ad9
Add comments for clarification and to get back into the project
tdittr Oct 24, 2023
fee22c2
Refactor serve packet
tdittr Oct 24, 2023
3db5a7e
Split up `serve_packet` into parts to seperate out IO
tdittr Oct 24, 2023
d19afcc
Move all non-IO handling into handle_packet
tdittr Oct 24, 2023
264879a
Move stats counter updating into its own function
tdittr Oct 24, 2023
cb77173
Streamline stats counting
tdittr Oct 24, 2023
9ee9d17
Flatten matches for better readability
tdittr Oct 24, 2023
caea97c
Move stat counting into the stats struct
tdittr Oct 24, 2023
657690a
Front load packet checks to de-clutter packet parsing
tdittr Oct 24, 2023
087f3ff
Fix comments and formatting
tdittr Oct 24, 2023
cf5a6f9
Remove explicit peer address from trace log
marlonbaeten Oct 24, 2023
84a3f69
clippy
folkertdev Oct 24, 2023
c7856c4
rename variable
folkertdev Oct 24, 2023
cc87495
inline `send_response`
folkertdev Oct 24, 2023
8d90e13
Remove unused return value
tdittr Oct 24, 2023
8ec5dba
Improve logging during packet_handling
tdittr Oct 24, 2023
d3aab78
Add a test for early returns
tdittr Oct 24, 2023
320d2e6
fixup! Add a test for early returns
tdittr Oct 24, 2023
e3fbfc7
fixup! Add a test for early returns
tdittr Oct 24, 2023
331971e
Add a test for handling of invalid packets
tdittr Oct 24, 2023
bff624b
Fix logging level to reduce logging load
tdittr Oct 24, 2023
b90ded1
Comment out tracing::instrument which breaks coverage collection...
tdittr Oct 24, 2023
2f04b0e
Limit the response buffer right at the start
tdittr Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading