Revert "penumbra: update ecosystem tendermint/ibc crates (#4980)" #4993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 64c32ef, which constitutes the squash-merge of PR #4980. We're backing this change out strictly to simplify release engineering: we want the `main` branch to remain fully compatible with the `0.81.x` series, and we'll continue QA of significant version changes in a parallel release branch, `release/v0.82.x`. I'll handle preparing the latter shortly. See related discussion in #4988 & #4991.
2 tasks
erwanor
approved these changes
Jan 17, 2025
conorsch
added a commit
that referenced
this pull request
Jan 17, 2025
conorsch
added a commit
that referenced
this pull request
Jan 19, 2025
conorsch
added a commit
that referenced
this pull request
Jan 20, 2025
## Describe your changes This PR backports #4993, which was made against the `release/v0.81.x` branch, to the `main` branch, so it's included in ongoing development. Co-authored-by: Henry de Valence <hdevalence@penumbralabs.xyz>
conorsch
added a commit
that referenced
this pull request
Jan 21, 2025
2 tasks
conorsch
added a commit
that referenced
this pull request
Jan 21, 2025
conorsch
added a commit
that referenced
this pull request
Jan 21, 2025
## Describe your changes Once again, we update significant dependencies on the main branch. Significantly, we've removed all git-dependencies from the workspace, which required upgrading `tonic` to upstream, which cascaded into other dependencies updates. With this change, we make the workspace nearly ready for publication to crates.io (#4978): still to come is a superficial refactor to rename the crates to `penumbra-sdk-*`, which I'll submit in a follow-up PR, to aid in review. This reverts commit a454870. ## Issue ticket number and link We've added and then removed this changeset a few times over the past week: * #4973 * #4980 * #4993 Now that we've tested it extensively, it's time to merge it into main and keep moving forward. Relevant version bumps were tracked in the following issues: * tonic #4400 * ibc-types #4682 * cnidarium #4956 * tendermint-rs (no issue) ## Testing and review In order to be certain that the changes honor protocol compatibility, I made sure to test syncing a mainnet fullnode based on this changeset from height 2622918—which is shortly after the change upgrade to 0.81.0—to 3136597, which is current height at time of writing. This gives us great confidence that the hard work toward ensuring that changes like #4682 were achieved in a compatible way. ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > see testing notes above: we're confident we've done the needful with this patch Co-authored-by: Erwan Or <erwanor@penumbralabs.xyz> Co-authored-by: Erwan Or <erwan.ounn.84@gmail.com> Co-authored-by: Richard Janis Goldschmidt <github@aberrat.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This reverts commit 64c32ef, which constitutes the squash-merge of PR #4980. We're backing this change out strictly to simplify release engineering: we want the
mainbranch to remain fully compatible with the0.81.xseries, and we'll continue QA of significant version changes in a parallel release branch,release/v0.82.x. I'll handle preparing the latter shortly.Issue ticket number and link
See related discussion in #4988 & #4991.
Testing and review
This is a programmatic change, in that I simply ran
git revert 64c32ef4b, wrote some notes into the commit message, and pushed it up. I also made sure to rerunjust prototo regenerate the protos, and confirmed there are no changes. That's good, that's precisely what we wanted to see.Preferably this change would land before #4992, since #4992 changes protos. I'll regenerate protos in 4992 on top of this once it lands on main.
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: