Windows support #39
Merged
Windows support #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfittl
force-pushed
the
windows-support
branch
from
5e56078
to
bf96e70
Compare
msepga
approved these changes
Jan 9, 2024
This avoids unnecessarily going through the Makefile logic, which isn't necessary when we have build.rs.
lfittl
force-pushed
the
windows-support
branch
from
bf96e70
to
462988d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this also removes our use of the
Makefileinbuild.rs, and instead uses thecccrate to build libpg_query directly. This matches what we do in other libraries (pg_query in Ruby, pg_query_go).Depends on pganalyze/libpg_query#233
Fixes #34