fix: typecheck tests using strict tsc mode #231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Oct 6, 2025
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
View your CI Pipeline Execution ↗ for commit 09fe21a
☁️ Nx Cloud last updated this comment at |
jumski
force-pushed
the
10-06-fix-typecheck-tests
branch
from
f18b09a to
569aad4
Compare
jumski
force-pushed
the
10-06-fix-typecheck-tests
branch
from
569aad4 to
09fe21a
Compare
🔍 Preview Deployment: Website✅ Deployment successful! 🔗 Preview URL: https://pr-231.pgflow.pages.dev 📝 Details:
_Last updated: _ |
🔍 Preview Deployment: Playground✅ Deployment successful! 🔗 Preview URL: https://pr-231--pgflow-demo.netlify.app 📝 Details:
_Last updated: _ |
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Oct 7, 2025
### TL;DR Improved TypeScript type checking with stricter validation and fixed map return type inference in the Flow DSL. ### What changed? - Added a new `typecheck-strict.sh` script that performs two-pass type checking: 1. Project-wide type check 2. Individual file checks to catch unused `@ts-expect-error` directives - Updated project.json files to use the new script for type checking - Made `test:types` a dependency of the main `test` target in multiple packages - Fixed type inference issues in the Flow DSL's map method by using `AwaitedReturn<THandler>[]` instead of `any[]` - Added new type tests in `map-return-type-inference.test-d.ts` to verify proper type inference - Cleaned up and improved existing type tests ### How to test? 1. Run the type checking with the new script: ```bash ./scripts/typecheck-strict.sh ``` 2. Run the type tests to verify the fixed map return type inference: ```bash pnpm nx test:types dsl ``` 3. Verify that the main test command now includes type checking: ```bash pnpm nx test dsl pnpm nx test client pnpm nx test core ``` ### Why make this change? The Flow DSL had a type inference bug where map step return types were incorrectly inferred as `any[]` instead of preserving the specific return type structure. This made it difficult to catch type errors in subsequent steps that used the map output. The new strict type checking process also helps catch unused `@ts-expect-error` directives, which can hide real type errors when they're no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Improved TypeScript type checking with stricter validation and fixed map return type inference in the Flow DSL.
What changed?
typecheck-strict.shscript that performs two-pass type checking:@ts-expect-errordirectivestest:typesa dependency of the maintesttarget in multiple packagesAwaitedReturn<THandler>[]instead ofany[]map-return-type-inference.test-d.tsto verify proper type inferenceHow to test?
Run the type checking with the new script:
Run the type tests to verify the fixed map return type inference:
Verify that the main test command now includes type checking:
Why make this change?
The Flow DSL had a type inference bug where map step return types were incorrectly inferred as
any[]instead of preserving the specific return type structure. This made it difficult to catch type errors in subsequent steps that used the map output. The new strict type checking process also helps catch unused@ts-expect-errordirectives, which can hide real type errors when they're no longer needed.