-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run write-manifest on PRs to dev
#773
Conversation
…nt into jt-772-gha_for_manifest2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #773 +/- ##
=======================================
Coverage 81.61% 81.61%
=======================================
Files 34 34
Lines 5277 5277
=======================================
Hits 4307 4307
Misses 970 970 ☔ View full report in Codecov by Sentry. |
…nt into jt-772-gha_for_manifest2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing comment review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing approval review
…nt into jt-772-gha_for_manifest2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval testing 2
…nt into jt-772-gha_for_manifest2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing approval 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval testing 4
@aclark02-arcus For some reason the checksum always updated for Thoughts? |
@aclark02-arcus I believe this has all the functionality we want now. Only negative I can think of now is that our normal checks are no longer sitting at the head of the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!
Addresses #772