Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add EMULATED define to CPPFLAGS for emulated targets #209

Closed
wants to merge 1 commit into from

Conversation

adamdebek
Copy link

JIRA: CI-501

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Copy link

github-actions bot commented Oct 7, 2024

Unit Test Results

7 725 tests  +2   7 010 ✅ +2   36m 57s ⏱️ -16s
  445 suites +2     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit b95d4ed. ± Comparison against base commit 4183f39.

@adamdebek adamdebek changed the title add EMULATED define to CPPFLAGS for emulated targets add EMULATED define to CPPFLAGS for emulated targets Oct 7, 2024
@adamdebek adamdebek requested a review from anglov October 7, 2024 12:48
Copy link
Member

@anglov anglov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no knowledge about reason why you want to add it. Maybe @nalajcie can help?

Anyways If you ask me, I don't like assuming about emulated or not target basing on TARGET_PROJECT. In current project we have emulated target riscv64-generic-spike

If you really need that variable, I would tihnk about passing it explicitly from _project files.

@adamdebek
Copy link
Author

After nalajcie comment here: phoenix-rtos/phoenix-rtos-tests#378, tihs pr is no longer relevant.

@adamdebek adamdebek closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants