-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libc: add passing custom parameter to unix-socket test #378
base: master
Are you sure you want to change the base?
Conversation
maybe it would be better to pass custom timeout param as a commandline param if possible (that way we will be able to provide custom values for any particular target requiring it?) |
371e861
to
887953c
Compare
887953c
to
32b45b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nitpicks, also 👍 for writing short/simple commit message titles
e5f5080
to
ddbba9b
Compare
ddbba9b
to
fa0f338
Compare
fa0f338
to
e5a3e81
Compare
8790843
to
12e5c5e
Compare
*/ | ||
for (int i = 1; i < argc; i++) { | ||
if (strcmp(argv[i], "--extra-poll-delay-ms") == 0) { | ||
pollTimeoutDelay = atoi(argv[i + 1]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should pollTimeoutDelay
ever be allowed to have negative value? If not, maybe it'd be good to have a simple argument value validation here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is passed directly in test.yaml, but I can add it.
12e5c5e
to
bae5e5a
Compare
Add passing custom parameter to unix-socket test on armv7a9-zynq7000-qemu since blocking interval significantly overruns timeout due to host system scheduling delays JIRA: CI-501
bae5e5a
to
7128227
Compare
…et test
JIRA: CI-501
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment