libc: add passing custom parameter to unix-socket test #378
+26
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe it would be better to pass custom timeout param as a commandline param if possible (that way we will be able to provide custom values for any particular target requiring it?) |
adamdebek
force-pushed
the
adamdebek/CI-501
branch
3 times, most recently
from
371e861
to
887953c
Compare
14 tasks
|
|
adamdebek
force-pushed
the
adamdebek/CI-501
branch
from
887953c
to
32b45b7
Compare
nalajcie
reviewed
Oct 9, 2024
adamdebek
force-pushed
the
adamdebek/CI-501
branch
2 times, most recently
from
e5f5080
to
ddbba9b
Compare
adamdebek
changed the title
adamdebek
force-pushed
the
adamdebek/CI-501
branch
from
ddbba9b
to
fa0f338
Compare
nalajcie
reviewed
Oct 9, 2024
adamdebek
force-pushed
the
adamdebek/CI-501
branch
from
fa0f338
to
e5a3e81
Compare
|
|
adamgreloch
reviewed
Oct 9, 2024
adamdebek
force-pushed
the
adamdebek/CI-501
branch
2 times, most recently
from
8790843
to
12e5c5e
Compare
adamgreloch
reviewed
Oct 9, 2024
| */ | ||
| for (int i = 1; i < argc; i++) { | ||
| if (strcmp(argv[i], "--extra-poll-delay-ms") == 0) { | ||
| pollTimeoutDelay = atoi(argv[i + 1]); |
There was a problem hiding this comment.
Should pollTimeoutDelay ever be allowed to have negative value? If not, maybe it'd be good to have a simple argument value validation here?
There was a problem hiding this comment.
It is passed directly in test.yaml, but I can add it.
adamdebek
force-pushed
the
adamdebek/CI-501
branch
from
12e5c5e
to
bae5e5a
Compare
Add passing custom parameter to unix-socket test on armv7a9-zynq7000-qemu since blocking interval significantly overruns timeout due to host system scheduling delays JIRA: CI-501
adamdebek
force-pushed
the
adamdebek/CI-501
branch
from
bae5e5a
to
7128227
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…et test
JIRA: CI-501
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment