-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cortex-M: NVIC and SCB code duplication cleanup #576
Conversation
6cf7ca5
to
43092c6
Compare
43092c6
to
ef753d4
Compare
191c1c9
to
3b69d3d
Compare
b65a447
to
248b216
Compare
3ed3dc5
to
8e01895
Compare
8e01895
to
2040e21
Compare
3748329
to
e072985
Compare
JIRA: RTOS-886
e072985
to
4762279
Compare
@anglov just to verify if it does not break your stuff |
I really like this change as it remove a lot of duplicated code. I check it on DEND (checked low power) and NIL projects and at the first glance it looks ok! Some general remarks (or ideas for future):
Current refactoring is great step in good direction anyways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge improvement, nice! Just two remarks (for the future, PR can be merged as-is):
- Check cache availability in
_hal_scbCacheIsSupported()
via Cache Control Identification Registers instead of relying solely oncpuid->PARTNO
, because cache is a silicon option. - A few functions are missing, e.g.
_imxrt_nvicGetPendingIRQ()
. They were not used, but maybe they should not be scrapped if code already exists.
Clenup standard part of Cortex-M component (i.e. SCB and NVIC) mass copy-paste across targets. If this approach passes, then it will be done over plo too
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment