-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imxrt-flash/imxrt117x: enable second flash memory & bug fixes #330
Conversation
3b339d4
to
ea9f325
Compare
c52ecee
to
6c600e7
Compare
Unit Test Results7 460 tests 6 745 ✅ 39m 3s ⏱️ Results for commit 9f4a26a. ♻️ This comment has been updated with latest results. |
#endif | ||
|
||
#ifndef FLEXSPI2_PORT_MASK | ||
#define FLEXSPI2_PORT_MASK flexspi_slBusA1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On imxrt-105x
there is only single FlexSPI instance. Add appropriate precompiler #error
in case if someone defines more than one instance.
@@ -247,20 +249,20 @@ | |||
|
|||
/* FLASH */ | |||
|
|||
#define FLASH_NO (FLASH_FLEXSPI1_MOUNTED + FLASH_FLEXSPI2_MOUNTED) | |||
#define FLASH_NO FLEXSPI_COUNT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously FLASH_FLEXSPI1_MOUNTED
and FLASH_FLEXSPI2_MOUNTED
were used to determine which instances are used in a project. On non-standard/custom boards it is possible to have only FLASH_FLEXSPI2_MOUNTED
instance and no FLASH_FLEXSPI1_MOUNTED
, so if FLEXSPI_COUNT=1
is set, you then always start with FLEXSPI1
and not FLEXSPI2
. Previous idea was more flexible from my point of view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it would be nice to have this feature however I don't think it was ever there. FLASH_*_MOUNTED defines were used only to set FLASH_NO. There was never support for using FLEXSPI2 memories only.
- flash memories are configurable through board_config.h (defaults are set for EVK boards) - set FLEXSPI2 clock to 132 MHz - initial flash size fix - flexspi_getAddressByPort() fix - change FLEXSPI1 SS0 pin on port B1 to SD_B1_4 (SD_B2_05 is already used for DQS on port A1) - fix _imxrt_setIOmux() parameters (mode and sion were switched) - code style changes JIRA: NIL-570
6c600e7
to
9f4a26a
Compare
JIRA: NIL-570
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment