Add sort-label-keys
#19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kj455 <kaji.ibuki45@gmail.com>
kj455
force-pushed
the
feat/sort-label-keys
branch
from
8864b02 to
223974f
Compare
kj455
commented
Feb 14, 2025
Comment on lines
+69
to
+71
| | timeout | Maximum amount of time to run. | no | 5m | | ||
| | piped-handle-timeout | Maximum amount of time to wait for piped handle the plan preview. | no | 5m | | ||
| | sort-label-keys | The application label keys to sort the results by. | no | "" | |
There was a problem hiding this comment.
The main change is in L71 with sort-label-keys, but I have also added some missing options (timeout, piped-handle-timeout).
There was a problem hiding this comment.
Thank you so much! we've missed them...
t-kikuc
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
LGTM
Please wait for a moment. We'll release this feature (next week?) in the following steps:
- Merge Sort results of plan-preview pipecd#5540
- Release the new version of pipectl in pipe-cd/pipecd (v0.50.2)
- Update the image version like this
- Release the new version of actions-plan-preview 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds the
sort-label-keysinput, related to pipecd/pipecd#5540.TODO:
Once the
sort-label-keysfeature is released, update the Docker image version, as in:pipe-cd/actions-plan-preview#17.