Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort-label-keys #19

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Add sort-label-keys #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,6 @@ jobs:
| address | The API address of PipeCD's control-plane. | yes | |
| api-key | The API key with READ_WRITE role used by pipectl while communicating with PipeCD's control-plane. | yes | |
| token | The GITHUB_TOKEN secret. | yes | |
| timeout | Maximum amount of time to run. | no | 5m |
| piped-handle-timeout | Maximum amount of time to wait for piped handle the plan preview. | no | 5m |
| sort-label-keys | The application label keys to sort the results by. | no | "" |
Comment on lines +69 to +71
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main change is in L71 with sort-label-keys, but I have also added some missing options (timeout, piped-handle-timeout).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! we've missed them...

5 changes: 5 additions & 0 deletions action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ inputs:
description: 'Maximum amount of time to wait for piped handle the plan preview. Default is 5m.'
required: false
default: 5m
sort-label-keys:
description: 'The application label keys to sort the results by. If not specified, the results will be sorted by only PipedID and ApplicationName.'
required: false
default: ''

runs:
using: 'docker'
Expand All @@ -30,6 +34,7 @@ runs:
- token=${{ inputs.token }}
- timeout=${{ inputs.timeout }}
- piped-handle-timeout=${{ inputs.piped-handle-timeout }}
- sort-label-keys=${{ inputs.sort-label-keys }}

branding:
icon: 'eye'
Expand Down