Reader: resolve BSD-variant file names before checking for symbol tables#23
Merged
chrisnovakovic merged 1 commit intoplease-build:masterfrom Nov 28, 2025
Conversation
Darwin's `ar(1)` writes BSD-variant archives and treats file names containing exactly 16 characters as long file names; this causes it to write sorted symbol tables with the file name `peterebden#1/16`, which only becomes `__.SYMDEF SORTED` after long file names have been resolved. Parse the file name before checking whether it is indicative of the archive member being a symbol table. Fixes #22.
toastwaffle
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Darwin's
ar(1)writes BSD-variant archives and treats file names containing exactly 16 characters as long file names; this causes it to write sorted symbol tables with the file name#1/16, which only becomes__.SYMDEF SORTEDafter long file names have been resolved. Parse the file name before checking whether it is indicative of the archive member being a symbol table.Fixes #22.