Skip to content

Reader: resolve BSD-variant file names before checking for symbol tables #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisnovakovic merged 1 commit into from
Nov 28, 2025
Merged

Reader: resolve BSD-variant file names before checking for symbol tables #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,14 +186,14 @@ func (rd *Reader) Next() (*Header, error) {
return nil, err
}
case BSD:
if err := rd.parseBSDFileName(header); err != nil {
return nil, err
}
// The special file name "__.SYMDEF" (and variations of it) indicates that the data section contains a symbol table.
if header.Name == "__.SYMDEF" || header.Name == "__.SYMDEF SORTED" || header.Name == "__.SYMDEF_64" {
// The symbol table should be invisible to the caller - skip over it.
return rd.Next()
}
if err := rd.parseBSDFileName(header); err != nil {
return nil, err
}
}

// The file name has now been resolved; make sure it doesn't contain any illegal characters.
Expand Down