use --hidden when querying what inputs#340
Merged
toastwaffle merged 1 commit intoplease-build:masterfrom Feb 4, 2026
Merged
Conversation
goddenrich
force-pushed
the
what-inputs-hidden
branch
from
f8ba42c to
8c4c9b7
Compare
toastwaffle
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plz query whatinputs without --hidden attempts to convert a hidden target into a non-hidden one. It makes the assumption that if there is a target with a _{name}#{hash} then there exists a non-hidden target called name within the same package. This is not necessarily true. Given we actually can use the hidden targets running plz query --hidden is safer since we are guaranteed to have a valid target.
This change also pipes the files into stdin rather than as an argument to the command. This avoids the issue where if there are too many files a fork errors due to the length of the arguments.