Skip to content

use --hidden when querying what inputs #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toastwaffle merged 1 commit into from
Feb 4, 2026
Merged

use --hidden when querying what inputs #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tools/driver/packages/packages.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,9 @@ func packagesToResponse(rootpath string, pkgs []*packages.Package, dirs map[stri
// A cooler way of handling this in future would be to do this in-process; for that we'd
// need to define the SDK we keep talking about as a supported programmatic interface.
func loadPackageInfo(files []string, mode packages.LoadMode) ([]*packages.Package, error) {
if len(files) == 0 {
return []*packages.Package{}, nil
}
isTerminal := term.IsTerminal(int(os.Stderr.Fd()))
plz := func(args ...string) *exec.Cmd {
cmd := exec.Command("plz", args...)
Expand All @@ -214,7 +217,8 @@ func loadPackageInfo(files []string, mode packages.LoadMode) ([]*packages.Packag
return nil, err
}
// N.B. deliberate not to close these here, they happen exactly when needed.
whatinputs := plz(append([]string{"query", "whatinputs", "--ignore_unknown" }, files...)...)
whatinputs := plz("query", "whatinputs", "--ignore_unknown", "--hidden", "-")
whatinputs.Stdin = strings.NewReader(strings.Join(files, "\n"))
whatinputs.Stdout = w1
args := []string{"query", "deps", "-", "--hidden", "-i", "go_pkg_info", "-i", "go_src"}
if (mode & packages.NeedExportFile) != 0 {
Expand Down