Andrew/mac subprocess fix #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayjayt
force-pushed
the
andrew/mac-subprocess-fix
branch
from
6bad539 to
3d37467
Compare
Closed
Also solves problem with temp files not getting deleted cause of crash
|
this guy builds on which_windows |
neyberson
reviewed
Sep 30, 2024
Wasn't necessary, Popen() communicates the arguments properly to mac w/o escaping the spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac is throwing some weird errors that linux doesn't throw for
asyncio.create_subprocess_exeWindows doesn't like that one either, fitting in with python's shoddy support of other OSes.
Let's go with a standard
suprocess.Popenwith anasyncio.to_threadand see how it goes.it wasn't that, it was mac not handling a
Pathwithoutstr()casting which is probably regrestive on their part but is good practice on our part to be explicit anyway