Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andrew/mac subprocess fix #95

Merged
merged 27 commits into from
Oct 1, 2024
Merged

Andrew/mac subprocess fix #95

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
ee9f5fe
Try running mac subprocess in thread w/o async
ayjayt Sep 27, 2024
1a12ff5
Improve DTDoctor
ayjayt Sep 27, 2024
6768fff
Add sync test to dtd and skip async test
ayjayt Sep 27, 2024
2a0b15a
Actually catch errors in try/except doh
ayjayt Sep 27, 2024
00eb56e
Collection exceptions for DTDoctor
ayjayt Sep 27, 2024
1f7fb09
Fix leftout vars
ayjayt Sep 27, 2024
185b2fa
Try catching asyncio exception from inside task
ayjayt Sep 27, 2024
3d37467
Try catching asyncio exception w/ error handler
ayjayt Sep 27, 2024
b2108f7
Skip async for now
ayjayt Sep 27, 2024
2d23ff1
Use tracebook to get full exception
ayjayt Sep 27, 2024
0cc101e
Cast path to str to help w/ mac fsencode
ayjayt Sep 27, 2024
47c8b9e
Remove unnecessary sol'n to_thread for mac Popen
ayjayt Sep 27, 2024
2611483
Add debug to which_browser
ayjayt Sep 27, 2024
3f5db32
Add missing import
ayjayt Sep 27, 2024
b641eda
Add missing comma :-(
ayjayt Sep 27, 2024
bf2b32b
Fix egregious variable swap
ayjayt Sep 27, 2024
73beca7
Unskip async test
ayjayt Sep 27, 2024
d46ac6d
Add Google Chome.app to list of possible exes
ayjayt Sep 27, 2024
7fc9612
Add some guards against unlikely None's
ayjayt Sep 27, 2024
cf4c746
Check exists() not isfile()
ayjayt Sep 27, 2024
981e8ac
Make string regular string
ayjayt Sep 27, 2024
10238a8
Look for bye in OSError, pipe:
ayjayt Sep 27, 2024
a1e7af0
Remove escaped string in system.py:
ayjayt Sep 30, 2024
24cf392
Merge branch 'main' into andrew/mac-subprocess-fix
ayjayt Oct 1, 2024
1790c38
Add missing file=sys.stderr
ayjayt Oct 1, 2024
6ecf20a
Store tempdir name out of unstable object
ayjayt Oct 1, 2024
91d18bc
Finish last commit, missing change
ayjayt Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devtools/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
else: # assume mac, or system == "Darwin"
default_path_chrome = [
"/Applications/Google Chrome.app/Contents/MacOS/Google Chrome",
"/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome",
r"/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome",
ayjayt marked this conversation as resolved.
Show resolved Hide resolved
]

def which_windows_chrome():
Expand Down
Loading