Open
Conversation
illusional
reviewed
Mar 28, 2023
Contributor
illusional
left a comment
illusional
left a comment
There was a problem hiding this comment.
Looking like awesome progress!
| '-c', | ||
| '--cloud', | ||
| required=False, | ||
| default=DEFAULT_CLOUD_ENVIRONMENT, |
Contributor
There was a problem hiding this comment.
Should we omit instead of provide a default? Which lets the analysis-runner decide the default
Comment on lines
124
to
138
| if environment == 'gcp': | ||
| # do this to check access-members cache | ||
| gcp_project = dataset_config.get('gcp', {}).get('projectId') | ||
|
|
||
| if not gcp_project: | ||
| raise web.HTTPBadRequest( | ||
| reason=f'The analysis-runner does not support checking group members for the {environment} environment' | ||
| ) | ||
| elif environment == 'azure': | ||
| azure_resource_group = dataset_config.get('azure', {}).get('resourceGroup') | ||
|
|
||
| if not azure_resource_group: | ||
| raise web.HTTPBadRequest( | ||
| reason=f'The analysis-runner does not support checking group members for the {environment} environment' | ||
| ) |
Contributor
There was a problem hiding this comment.
You can remove this, group member checks are not in secrets, therefore no gcp_project ID is needed anymore (I think):
Suggested change
| if environment == 'gcp': | |
| # do this to check access-members cache | |
| gcp_project = dataset_config.get('gcp', {}).get('projectId') | |
| if not gcp_project: | |
| raise web.HTTPBadRequest( | |
| reason=f'The analysis-runner does not support checking group members for the {environment} environment' | |
| ) | |
| elif environment == 'azure': | |
| azure_resource_group = dataset_config.get('azure', {}).get('resourceGroup') | |
| if not azure_resource_group: | |
| raise web.HTTPBadRequest( | |
| reason=f'The analysis-runner does not support checking group members for the {environment} environment' | |
| ) |
server/util.py
Outdated
| if environment == 'gcp': | ||
| output_dir = f'gs://cpg-{dataset}-{cpg_namespace(access_level)}/{output_prefix}' | ||
| elif environment == 'azure': | ||
| # TODO: need a way for analysis runner to know where to save metadata |
Contributor
There was a problem hiding this comment.
It follows the same sort of convention right, where storage-account is cpg{datasetWithoutTabs}
azure://{storage-account}/{main,test}/{output_prefix}
| import hailtop.batch as hb | ||
|
|
||
|
|
||
| @click.command() |
Contributor
There was a problem hiding this comment.
There are a couple of test workflows in examples/batch, can you use them or move this one to there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to the analysis runner to enable Azure compatability.