Open
Conversation
MattWellie
reviewed
Mar 11, 2024
| # Move the tarball to the "completed" directory | ||
| subprocess.run( | ||
| [ | ||
| 'gsutil', |
Contributor
There was a problem hiding this comment.
in the spirit of modernisation can we bump this to gcloud storage
MattWellie
approved these changes
Mar 11, 2024
Contributor
|
Does it need to also look in the AIUI renaming — even within the same bucket — is not a free operation and is really a copy+delete. I'm probably overthinking this, but could we instead attach some metadata saying it's been done? (I haven't used this API so don't know if this is even feasible…) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically moves the tar file to a
/completedfolder upon successfully extracting its contents.This means that if the batch has to be re-run on the same bucket path due to one or more job failures, the tarballs that were successfully extracted will no longer be picked up and queued for re-extraction.