Skip to content

Added CODEOWNERS file #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nevoodoo merged 1 commit into from
Nov 17, 2025
Merged

Added CODEOWNERS file #741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
* @populationgenomics/software-team
/scripts/ @populationgenomics/genomic-analysis-team @populationgenomics/software-team
Comment on lines +1 to +2
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of patterns in CODEOWNERS is incorrect. In CODEOWNERS files, more specific patterns must be placed before more general patterns, otherwise they won't override the default.

Currently, line 1 (*) matches everything including /scripts/, so line 2's pattern is redundant. To achieve the stated goal where the genomic-analysis-team can approve changes in /scripts/ without requiring software-team approval, you should:

  1. Move the /scripts/ pattern to line 1
  2. Move the * pattern to line 2

Corrected order:

/scripts/ @populationgenomics/genomic-analysis-team
* @populationgenomics/software-team

This way, scripts folder changes only require genomic-analysis-team approval, while all other files require software-team approval.

Suggested change
* @populationgenomics/software-team
/scripts/ @populationgenomics/genomic-analysis-team @populationgenomics/software-team
/scripts/ @populationgenomics/genomic-analysis-team
* @populationgenomics/software-team

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@dancoates dancoates Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this is wrong, the documentation here:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
states that "Order is important; the last matching pattern takes the most precedence."

Loading