Refine update generic https transfer#748
Merged
amyminiter merged 13 commits intomainfrom Jan 23, 2026
Merged
Conversation
Contributor
Author
|
@EddieLF thoughts on replacing Considerations (most
|
folded
reviewed
Jan 22, 2026
folded
reviewed
Jan 22, 2026
…ulationgenomics/analysis-runner into refine_update_generic_https_transfer
EddieLF
approved these changes
Jan 23, 2026
Contributor
EddieLF
left a comment
There was a problem hiding this comment.
LGTM, I love discovering this match & case syntax added in python 3.10.
Also happy for you to update gsutil to gcloud storage if you're satisfied that it's totally compatible. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporate changes from comments from @folded to refine
generic_https_transfer:--use-wgetwithwget|curlsupports scalabilityquote()for destination path to protect URL.