Optionally intercept standard Python logging and redirect to loguru handler#124
Open
Optionally intercept standard Python logging and redirect to loguru handler#124
Conversation
…andler As per loguru documentation (see the "Entirely compatible with standard logging" section).
Contributor
📊 SonarQube Summary
|
Contributor
🐳 Docker Image BuiltA new Docker image has been built for this PR: Image: Pull command: docker pull australia-southeast1-docker.pkg.dev/cpg-common/images-dev/cpg_flow:d8f3b5a361b9ca90f74b21bf090ffa1afeab3ce1🔗 View in Google Cloud Console This comment was automatically generated by the Docker workflow. |
dancoates
approved these changes
Aug 18, 2025
dancoates
left a comment
dancoates
left a comment
There was a problem hiding this comment.
Looks good, a bit of a fiddly implementation but as per the docs you linked this does seem to be the advised way to have loguru intercept standard logging.
Contributor
Author
|
Indeed… You would think loguru could provide a suitable default InterceptHandler rather than inviting everyone to write it themselves… ETA: Requested three years ago: Delgan/loguru#633. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the loguru documentation.
See batch 631674 which ran on an image that includes this PR — note the log ends with log messages from modules within
/cpg-flow/.venv/lib/…whereas batch 631672 is of similar vintage but does not contain this PR and omits these log messages.Before merging this, we would need to consider whether we facilitate cpg-flow-using workflows that prefer standard logging rather than loguru, and what the desired behaviour there would be — perhaps to redirect cpg-flow's loguru messages to the standard logger instead.