Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non pre-emptible gVCF combiner jobs #1096

Merged
merged 2 commits into from
Jan 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bumpversion.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 1.32.12
current_version = 1.32.13
commit = True
tag = False

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ permissions:
contents: read

env:
VERSION: 1.32.12
VERSION: 1.32.13

jobs:
docker:
Expand Down
2 changes: 2 additions & 0 deletions configs/defaults/rd_combiner.toml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ driver_storage = "10Gi"
driver_cores = 1
# highem, standard, or a string, e.g. "4Gi"
worker_memory = "standard"
# if false, use non-preemptible VMs
preemptible_vms = false

[vqsr]
# VQSR, when applying model, targets indel_filter_level and snp_filter_level
Expand Down
4 changes: 4 additions & 0 deletions cpg_workflows/stages/rd_combiner.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,10 @@ def queue_jobs(self, multicohort: MultiCohort, inputs: StageInput) -> StageOutpu
combiner_job.storage(config_retrieve(['combiner', 'driver_storage']))
combiner_job.cpu(config_retrieve(['combiner', 'driver_cores'], 2))

# set this job to be non-spot (i.e. non-preemptible)
# previous issues with preemptible VMs led to multiple simultaneous QOB groups processing the same data
combiner_job.spot(config_retrieve(['combiner', 'preemptible_vms'], False))

# Default to GRCh38 for reference if not specified
combiner_job.call(
combiner.run,
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
setup(
name='cpg_workflows',
# This tag is automatically updated by bumpversion
version='1.32.12',
version='1.32.13',
description='CPG workflows for Hail Batch',
long_description=open('README.md').read(),
long_description_content_type='text/markdown',
Expand Down
Loading