Removing options for biobambam as tool for marking duplicates #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o allow for flexibility of MarkDupTool.NO_MARKDUP in the case we don't want to perform marking of duplicates and to ensures tests don't break
MattWellie
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
LGTM, easy little nibble at the bigger problem. Can you add a bump2version patch version update, and just check in with @katiedelange /PA before merging
MattWellie
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
=======================================
Coverage 26.72% 26.72%
=======================================
Files 9 9
Lines 1729 1729
=======================================
Hits 462 462
Misses 1267 1267 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #871
We are wanting to simplify the alignment job and remove unsupported and unused configurations. This will help future efforts for version control.
This PR removes the option to use
Biobambamto mark duplicates in favour ofpicard.