Use Target.get_job_attrs() and propagate to Batch.new_job() calls#17
Merged
Use Target.get_job_attrs() and propagate to Batch.new_job() calls#17
Conversation
vivbak
approved these changes
Aug 14, 2025
|
|
||
| # Merge the no evens lists for all sequencing groups into a single file | ||
| job = b.new_job(name=title) | ||
| job = b.new_job(name=title, attributes=job_attrs | {'tool': 'cat'}) |
Contributor
Author
There was a problem hiding this comment.
Yep 😸
The command for this job is just job.command(f'cat {inputs} >> {job.pyramid}'). But really this is just an example of unioning in some more attributes entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production-pipelines code generally uses
b.new_job('name_of_job', job_attrs | {'tool': 'used_tool'})when setting up Hail jobs, wherejob_attrsis passed in from the stage viaself.get_job_attrs(sequencing_group/cohort/whatever).This PR changes test_workflows_shared to do the same thing. Previously the resulting Hail batch jobs have not had (most of) their job attributes set up.