Project Software Review

Review Day - 1 (9th March, 2016)

Ideas

1. Data persistence has dependencies on two packages, namely javax.persistence and org.springframework.data.jpa. Can this be reduced to just one dependency on either javax.persistence or spring?[Answered]
2. For converting byte sequences from Network Byte Order (BIT_ENDIAN) to local byte order while converting to short or int, should we use any libraries or define our own custom methods similar to htons function in C?[Reviewing]
   • Some suggestions - Spring integration
3. Move certain classes in util package to appropriate classes. Change their access from public to protected[DONE]
4. Remove unnecessary packages like - formatter, mvc.services and so on.[DONE]
5. p4lang java backend**[WIP]**

Review

1. It is not really possible to decrease the number of dependencies to one. Because we are persisting java objects using a relational database we have to use Java Persistence API (JPA) which is defined in javax.persistence package. See here. Spring Data JPA only helps accessing these persisted entities by avoiding the need to introduce much boilerplate code intermediately. References -
   • http://www.baeldung.com/2011/12/22/the-persistence-layer-with-spring-data-jpa/
   • Spring Data - In the intro itself it says ..Spring-based programming model for data access..
2. Currently I am considering this solution. Bringing in Spring Integration will require more review.
3. Done. Moved the EventBusFactory class to analyzer package. Removed the access modifier "public" (resulting in default access level - package private)
4. Done.