feat: add pixi global install
#2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hofer-Julian
force-pushed
the
feat/pixi-global-install
branch
from
f0ce8a5
to
a1c7c01
Compare
|
The latest changes are done to refactor the project some more to also do the binary cleaning per environment instead of in general. This should also fix the issue we had with the integration tests where we wouldn't delete old binaries in |
|
I'll fix the tests today. |
|
The main differences between @Hofer-Julian's first implementation and the refactored version is that we now don't sync on install we only install the requested environments and this also cleanup those. |
baszalmstra
reviewed
Sep 30, 2024
src/global/project/environment.rs
Outdated
Comment on lines
67
to
99
| // struct GlobalEnvironment { | ||
| // name: EnvironmentName, | ||
| // prefix: Prefix, | ||
| // parsed_environment: ParsedEnvironment, | ||
| // } | ||
| // | ||
| // impl GlobalEnvironment { | ||
| // /// Create a new global environment object. | ||
| // pub(crate) fn new( | ||
| // name: EnvironmentName, | ||
| // env_root: EnvRoot, | ||
| // parsed_environment: ParsedEnvironment, | ||
| // ) -> Self { | ||
| // let prefix = Prefix::new(env_root.path().join(name.as_str().into())); | ||
| // Self { | ||
| // name, | ||
| // prefix, | ||
| // parsed_environment, | ||
| // } | ||
| // } | ||
| // | ||
| // /// Returns the name of the environment. | ||
| // pub fn name(&self) -> &EnvironmentName { | ||
| // &self.name | ||
| // } | ||
| // | ||
| // /// Returns the prefix of the environment. | ||
| // pub fn prefix(&self) -> &Prefix { | ||
| // &self.prefix | ||
| // } | ||
| // | ||
| // | ||
| // } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.