Rename MON_ID to MON_OT_ID
#1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constant name MON_ID implies it relates to the ID number of the Pokémon itself. However, it actually refers to the Trainer ID number of the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it substantially more clear what its purpose is. The original definition of MON_ID is preserved in macros/legacy.asm
Rangi42
reviewed
Feb 25, 2024
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>
|
Calling it |
Rangi42
approved these changes
Apr 14, 2024
|
I agree |
vulcandth
approved these changes
Apr 24, 2024
|
I agree on MON_OT_ID, since we use the OT term everywhere. |
vulcandth
added a commit
to pret/pokegold
that referenced
this pull request
Apr 27, 2024
* Rename MON_ID to MON_TRAINER_ID The constant name MON_ID implies it relates to the ID number of the Pokémon itself. However, it actually refers to the Trainer ID number of the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it substantially more clear what its purpose is. The original definition of MON_ID is preserved in macros/legacy.asm * Remove MON_ID from macros/legacy.asm Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com> * Apply rename to missed file * Rename to `MON_OT_ID` --------- Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com> Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com> Co-authored-by: vulcandth <vulcandth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constant name MON_ID implies it relates to the ID number of the Pokémon itself; however, it actually refers to the Trainer ID number of the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it substantially more clear what its meaning is.
The original definition of MON_ID is preserved in
macros/legacy.asm