Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MON_ID to MON_OT_ID #1114

Merged
merged 4 commits into from
Apr 27, 2024
Merged

Rename MON_ID to MON_OT_ID #1114

merged 4 commits into from
Apr 27, 2024

Commits on Feb 25, 2024

  1. Rename MON_ID to MON_TRAINER_ID 

    The constant name MON_ID implies it relates to the ID number of the
Pokémon itself. However, it actually refers to the Trainer ID number of
the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it
substantially more clear what its purpose is.

The original definition of MON_ID is preserved in macros/legacy.asm
    @SnorlaxMonster
    SnorlaxMonster committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    e1a7ee6 View commit details
    Browse the repository at this point in the history

  2. Remove MON_ID from macros/legacy.asm 

    Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>
    @SnorlaxMonster @Rangi42
    SnorlaxMonster and Rangi42 authored Feb 25, 2024
    Configuration menu
    Copy the full SHA
    3578e51 View commit details
    Browse the repository at this point in the history

  3. Apply rename to missed file

    @SnorlaxMonster
    SnorlaxMonster committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    1c6f6d2 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Rename to MON_OT_ID

    @vulcandth
    vulcandth committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    45f7c94 View commit details
    Browse the repository at this point in the history