This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Remove assembly in geth-utils #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate-geth-utils
Brechtpd
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Looks good! If I remember correctly, I copied these files into this project because they were part of Han's code for generating these traces that I basically just copied. I guess even at the time it was pretty unlikely this would ever get used here so I probably should not have included them in the first place, so good that these are finally removed! Thanks for cleaning things up.
|
@Brechtpd My pleasure! Thank you for elaborating on the background of the decision. |
lispc
pushed a commit
to scroll-tech/zkevm-circuits
that referenced
this pull request
Sep 2, 2023
Remove geth-utils and examples. New feature (non-breaking change which adds functionality) - Assembly was introduced in #91 to build examples to use geth-util. It was not used elsewhere in the codebase. - The examples are removed as we currently don't use geth-util like the way the examples show. (Note that the examples also fail to run now. The transactions in the examples would fail because the trace config defaults to a 0 block gas limit. It runs after adding a block gas limit.) - I found those examples unused when reviewing how we use the tracing API. It is much easier to review the tracing code after removing the Assembly. - The Readme mentioned a TODO CLI, which we never built. I think it might be interesting to create a good first issue for people to extend testool(https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/690b2f143a94b7474f0c99493a99b0f2c53d93b8/testool/README.md#L38) for it.
lispc
added a commit
to scroll-tech/zkevm-circuits
that referenced
this pull request
Sep 2, 2023
* Remove assembly in geth-utils (privacy-scaling-explorations#1553) Remove geth-utils and examples. New feature (non-breaking change which adds functionality) - Assembly was introduced in #91 to build examples to use geth-util. It was not used elsewhere in the codebase. - The examples are removed as we currently don't use geth-util like the way the examples show. (Note that the examples also fail to run now. The transactions in the examples would fail because the trace config defaults to a 0 block gas limit. It runs after adding a block gas limit.) - I found those examples unused when reviewing how we use the tracing API. It is much easier to review the tracing code after removing the Assembly. - The Readme mentioned a TODO CLI, which we never built. I think it might be interesting to create a good first issue for people to extend testool(https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/690b2f143a94b7474f0c99493a99b0f2c53d93b8/testool/README.md#L38) for it. * rewrite geth_utils with go.work * fix make doc --------- Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove geth-utils and examples.
Type of change
New feature (non-breaking change which adds functionality)
Rationale
zkevm-circuits/testool/README.md
Line 38 in 690b2f1