Skip to content

Add XpubAnnounce and on_xpub_announced to UDL bindings#286

Merged
kwsantiago merged 2 commits intomainfrom
xpub-announce-udl
Feb 27, 2026
Merged

Add XpubAnnounce and on_xpub_announced to UDL bindings#286
kwsantiago merged 2 commits intomainfrom
xpub-announce-udl

Conversation

@kwsantiago
Copy link
Contributor

@kwsantiago kwsantiago commented Feb 27, 2026

Summary by CodeRabbit

  • New Features
    • Added support for announcing multiple extended public keys with metadata, including fingerprints and optional labels, to the wallet.

@kwsantiago kwsantiago self-assigned this Feb 27, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2026

Warning

Rate limit exceeded

@kwsantiago has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 15 minutes and 44 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between ba3f359 and 16c1165.

📒 Files selected for processing (2)
  • keep-desktop/src/frost.rs
  • keep-desktop/src/message.rs

Walkthrough

Extended public key (xpub) announcement support added to the mobile wallet interface. Introduces AnnouncedXpubInfo dictionary and corresponding wallet_announce_xpubs method alongside a descriptor callback hook for handling announced keys.

Changes

Cohort / File(s) Summary
Mobile Interface Extensions
keep-mobile/src/keep_mobile.udl
Added AnnouncedXpubInfo dictionary (xpub, fingerprint, optional label) and wallet_announce_xpubs method to KeepMobile interface. Introduced on_xpub_announced callback to DescriptorCallbacks for handling share index-based xpub announcements.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 Xpubs announced with grace,
Keys dancing through wallet space,
Callbacks whisper share by share,
Extended publics, free to share!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main changes: adding XpubAnnounce-related functionality (AnnouncedXpubInfo dictionary) and on_xpub_announced callback to UDL bindings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch xpub-announce-udl

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kwsantiago kwsantiago merged commit 17da874 into main Feb 27, 2026
9 checks passed
@kwsantiago kwsantiago deleted the xpub-announce-udl branch February 27, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant