Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more debugging log on generating crd related code. #6117

Conversation

lubronzhan
Copy link
Contributor

Currently, the check-uncommited-codegen shows there are uncommited change, but not the details of the change. So add some command to help debug

  1. print git diff if there is diff
  2. print controller-gen version, since sometimes it could just because the controller-gen version is incorrect, then the generated output is different between remote job and local environment

… useful

Signed-off-by: Lubron Zhan <lubronzhan@gmail.com>
@lubronzhan lubronzhan requested a review from a team as a code owner January 22, 2024 22:19
@lubronzhan lubronzhan requested review from skriss and sunjayBhatia and removed request for a team January 22, 2024 22:19
@sunjayBhatia sunjayBhatia requested review from a team, davinci26 and izturn and removed request for a team January 22, 2024 22:19
@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ae0bfa) 78.85% compared to head (cfb4815) 78.84%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6117      +/-   ##
==========================================
- Coverage   78.85%   78.84%   -0.01%     
==========================================
  Files         138      138              
  Lines       19731    19730       -1     
==========================================
- Hits        15558    15557       -1     
  Misses       3870     3870              
  Partials      303      303              
Files Coverage Δ
...ernal/provisioner/objects/deployment/deployment.go 88.98% <100.00%> (-0.05%) ⬇️

Signed-off-by: Lubron Zhan <lubronzhan@gmail.com>
@sunjayBhatia sunjayBhatia merged commit 3fa8ec4 into projectcontour:main Jan 23, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants