Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more debugging log on generating crd related code. #6117

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Add more debugging log on generating crd related code. #6117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e89b6d4
Add more debugging log on generating crd related code. So it would be…
lubronzhan Jan 22, 2024
cfb4815
Resolve comments
lubronzhan Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hack/actions/check-uncommitted-codegen.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,6 @@ if git status -s ${TARGETS[@]} 2>&1 | grep -E -q '^\s+[MADRCU]'
then
echo Uncommitted changes in generated sources:
git status -s ${TARGETS[@]}
git diff
lubronzhan marked this conversation as resolved.
Show resolved Hide resolved
exit 1
fi
3 changes: 3 additions & 0 deletions hack/generate-crd-deepcopy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ readonly HEADER=$(mktemp)

boilerplate > "${HEADER}"

exec echo "controller-gen version: "
exec go run sigs.k8s.io/controller-tools/cmd/controller-gen --version

exec go run sigs.k8s.io/controller-tools/cmd/controller-gen \
"object:headerFile=${HEADER}" \
"paths=${PATHS}"
3 changes: 3 additions & 0 deletions hack/generate-crd-yaml.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ trap 'rm -rf "$TEMPDIR"; exit' 0 1 2 15

cd "${REPO}"

echo "controller-gen version: "
go run sigs.k8s.io/controller-tools/cmd/controller-gen --version

# Controller-gen seems to use an unstable sort for the order of output of the CRDs
# so, output them to separate files, then concatenate those files.
# That should give a stable sort.
Expand Down
3 changes: 3 additions & 0 deletions hack/generate-rbac.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ cat > "${REPO}/examples/contour/02-role-contour.yaml" <<EOF
# files and re-render.
EOF

echo "controller-gen version: "
go run sigs.k8s.io/controller-tools/cmd/controller-gen --version

go run sigs.k8s.io/controller-tools/cmd/controller-gen \
rbac:roleName=contour \
output:stdout \
Expand Down
Loading