Respect the with_spans parser option for annotations#201
Merged
eemeli merged 2 commits intoprojectfluent:mainfrom Jul 26, 2024
Merged
Respect the with_spans parser option for annotations#201eemeli merged 2 commits intoprojectfluent:mainfrom
with_spans parser option for annotations#201eemeli merged 2 commits intoprojectfluent:mainfrom
Conversation
Prior to this change, all of the syntax tests covered the behaviour of the parser when with_spans is set to True. This change updates the test generation to create a version of each test which tests the parser when with_spans is set to False. To achieve this, we strip the span information from the expected file (rather than needing to maintain two files).
Prior to this change, Annotations would always have span information, irrespective of the value of the with_spans argument to the parser. This change changes the behaviour to only include span information if with_spans if set to True.
leamingrad
force-pushed
the
respect-with-spans-for-annotations
branch
from
1193629 to
7cb7fac
Compare
eemeli
approved these changes
Jul 25, 2024
Member
eemeli
left a comment
eemeli
left a comment
There was a problem hiding this comment.
This looks sensible. Apologies for taking so long to get at this.
It looks like there was a CI run for this that complained on flake, but it's not showing up in the PR?
Member
|
Ah, the lint problem was fixed by the force push. Still confused by the CI results not showing up here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a small change to stop adding span information to
Annotationelements whenwith_spansis set toFalsefor the parser.I've pulled this into its own PR because it wasn't obvious whether this behaviour was intentional or not (I could see an argument that annotations are a bit useless without span information). If this isn't needed, I'm happy to close this PR.
Note that the broken tests are unrelated to this PR, and are fixed in #203.