deps: Update whats-my-line
to bump dugite
to 2.1.0
#36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Summary
This switches
whats-my-line
to Pulsar's fork, via github.com tarball URL off of the fork repo, but a non-master
branch to specifically pull in thedugite
version bump/pin to 2.1.0, matching the version that's pinned here.Why? To dedupe
dugite
in core repo, which is a pretty hefty ~35.5 MB dependency (on macOS, at least).Changes
pulsar-edit
org made in thewhats-my-line
forkContains (effectively) the following
whats-my-line
PRs over at our fork:package.json
version whats-my-line#2dugite
to2.1.0
whats-my-line#7 (pending PR, at the time I'm writing this, but cherry-picked onto a custom branch to exclude the following PRs:)Does not include the following
whats-my-line
PRs:https://github.com/pulsar-edit/whats-my-line/pull/5
https://github.com/pulsar-edit/whats-my-line/pull/6
Those changes can wait until the
superstring
update efforts are more set in stone, synced across all relevant repos, and tested properly (ended up being a bigger project than thedugite
stuff.)Context
Updating from a non-
master
branch commit ofwhats-my-line
repo for now, to get thedugite
version syncing/deduping effort landed in core repo sooner, since thesuperstring
stuff is taking longer than thedugite
stuff.(The commit from
whats-my-line
repo used in this PR is https://github.com/pulsar-edit/whats-my-line/tree/348e8d10d9b9a1fd717cd4cc1263297844732768, AKA https://github.com/pulsar-edit/whats-my-line/tree/just-the-dugite-2.1.0-bump.)There's no sense delaying the
dugite
stuff just to do thesuperstring
stuff together at the same (potentially much later) time. Better to get each done "right" and land each when it's ready, IMO.So here's this. No
superstring
bumps, just pinningdugite
to 2.1.0Meta Stuff: PR Coordination at this Repo
This is kind of an alternative to/subset of #35 to get the
dugite
stuff shipped faster, since it's ready and Regular release day for the Pulsar editor is coming soon, and the the wholesuperstring
,keytar
,win-iconv
shenanigans is still ongoing at the time I'm writing this, delaying the completion of #35 and related efforts.I would intend to just re-work the
whats-my-line
update in that PR (just by rebasing over top of this PR) if this PR merges first.