Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update whats-my-line to bump dugite to 2.1.0 #36

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Nov 14, 2023

Short Summary

This switches whats-my-line to Pulsar's fork, via github.com tarball URL off of the fork repo, but a non-master branch to specifically pull in the dugite version bump/pin to 2.1.0, matching the version that's pinned here.

Why? To dedupe dugite in core repo, which is a pretty hefty ~35.5 MB dependency (on macOS, at least).

Changes pulsar-edit org made in the whats-my-line fork

Contains (effectively) the following whats-my-line PRs over at our fork:

Does not include the following whats-my-line PRs:

  • https://github.com/pulsar-edit/whats-my-line/pull/5
  • https://github.com/pulsar-edit/whats-my-line/pull/6

Those changes can wait until the superstring update efforts are more set in stone, synced across all relevant repos, and tested properly (ended up being a bigger project than the dugite stuff.)

Context

Updating from a non-master branch commit of whats-my-line repo for now, to get the dugite version syncing/deduping effort landed in core repo sooner, since the superstring stuff is taking longer than the dugite stuff.

(The commit from whats-my-line repo used in this PR is https://github.com/pulsar-edit/whats-my-line/tree/348e8d10d9b9a1fd717cd4cc1263297844732768, AKA https://github.com/pulsar-edit/whats-my-line/tree/just-the-dugite-2.1.0-bump.)

There's no sense delaying the dugite stuff just to do the superstring stuff together at the same (potentially much later) time. Better to get each done "right" and land each when it's ready, IMO.

So here's this. No superstring bumps, just pinning dugite to 2.1.0

Meta Stuff: PR Coordination at this Repo

This is kind of an alternative to/subset of #35 to get the dugite stuff shipped faster, since it's ready and Regular release day for the Pulsar editor is coming soon, and the the whole superstring, keytar, win-iconv shenanigans is still ongoing at the time I'm writing this, delaying the completion of #35 and related efforts.

I would intend to just re-work the whats-my-line update in that PR (just by rebasing over top of this PR) if this PR merges first.

Updating from a non-`master` branch commit of `whats-my-line` repo
for now, to get the `dugite` version syncing/deduping effort landed in
core repo sooner, since the `superstring` stuff is taking longer than
the `dugite` stuff.

There's no sense delaying the `dugite` stuff just to do
the `superstring` stuff together at the same (potentially much later)
time. Better to get each done "right" and land each when it's ready,
IMO.

So here's this. No `superstring` bumps, just pinning `dugite` to 2.1.0
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeeDeeG This looks awesome and amazing effort!

Thanks a ton for coordinating all of this together!

Also for whoever eventually brings this github bump into core, it's very worth asking to please include this whats-my-line changelog that DeeDee has helpfully made in the PR body in pulsar.

Helps a ton in creating the changelog down the road. But overall, looks great and lets get this merged!

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Nov 14, 2023

Thanks for review, and I'll go ahead and merge now!

And looking ahead past this PR itself:

Intending to eventually package this up in a pre-transpiled tag of github package, and get this in core via: pulsar-edit/pulsar#799 (or any follow-up PR if that one gets closed for whatever reason.)

@DeeDeeG DeeDeeG merged commit 27abae1 into master Nov 14, 2023
0 of 5 checks passed
@DeeDeeG DeeDeeG mentioned this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants