deps: Update github
, for dugite
deduping purposes
#799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Summary
Updating
github
package to v0.36.18-pretranspiled.whats-my-line
which pinsdugite
to the same version (2.1.0) used by our fork of thegithub
package.Motivation (deduping
dugite
, reducing Pulsar binary size)The goal is mainly to reduce the binary sizes for Pulsar, by deduping
dugite
. This is a large dependency that downloads severalgit
andgit
-related binaries during its install. Having multiple different versions is wasteful of filesize on disk, and doesn't provide any known benefit. Deduping is a smart way to reduce the overall size of the Pulsar app bundles for the various platforms.Before:
After:
Included Pull Requests
Includes the following PR over at
github
repo:whats-my-line
to bumpdugite
to 2.1.0 github#36This in turn brings in the
pulsar-edit
fork of thewhats-my-line
dependency. Includes the followingwhats-my-line
PRs, effectively:package.json
version whats-my-line#2dugite
to2.1.0
whats-my-line#7 (pending PR, at the time I'm writing this, but cherry-picked onto a custom branch to exclude the following PRs:)Does not include the following
whats-my-line
PRs:https://github.com/pulsar-edit/whats-my-line/pull/5
https://github.com/pulsar-edit/whats-my-line/pull/6
Those changes can wait until the
superstring
update efforts are more set in stone, synced across all relevant repos, and tested properly (ended up being a bigger project than thedugite
stuff.)