Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update github, for dugite deduping purposes #799

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Nov 14, 2023

Short Summary

Updating github package to v0.36.18-pretranspiled.

  • Switches to our fork of whats-my-line which pins dugite to the same version (2.1.0) used by our fork of thegithub package.

Motivation (deduping dugite, reducing Pulsar binary size)

The goal is mainly to reduce the binary sizes for Pulsar, by deduping dugite. This is a large dependency that downloads several git and git-related binaries during its install. Having multiple different versions is wasteful of filesize on disk, and doesn't provide any known benefit. Deduping is a smart way to reduce the overall size of the Pulsar app bundles for the various platforms.

Before:

Binary name File Size
macos-latest Binaries 465 MB
ubuntu-20.04 Binaries 707 MB
windows-latest Binaries 543 MB

After:

Binary name File Size
macos-latest Binaries 419 MB
ubuntu-20.04 Binaries 676 MB
windows-latest Binaries 495 MB

Included Pull Requests

Includes the following PR over at github repo:

This in turn brings in the pulsar-edit fork of the whats-my-line dependency. Includes the following whats-my-line PRs, effectively:

Does not include the following whats-my-line PRs:

  • https://github.com/pulsar-edit/whats-my-line/pull/5
  • https://github.com/pulsar-edit/whats-my-line/pull/6

Those changes can wait until the superstring update efforts are more set in stone, synced across all relevant repos, and tested properly (ended up being a bigger project than the dugite stuff.)

For `dugite` deduping purposes -- dedupes `dugite` to pinned 2.1.0.
@DeeDeeG DeeDeeG force-pushed the update-github-for-dugite-deduping-reasons branch from d39d129 to 835c735 Compare November 14, 2023 21:05
@DeeDeeG DeeDeeG marked this pull request as ready for review November 14, 2023 23:09
@DeeDeeG
Copy link
Member Author

DeeDeeG commented Nov 14, 2023

Alright, this is ready for review.

Paging @confused-Techie whose idea it was to do the dugite deduping in the first place, and whose PRs in whats-my-line are all the actual work in this (besides syncing that stuff across whats-my-line, github, and now here in Pulsar core repo, which I worked on).

This is basically @confused-Techie's work, I just did the task of bumping things/dependency herding/lining up branches/tags to include that work in the necessary places, and helping review PRs/make suggestions there.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I just say looking through the changes of this yarn.lock is a thing of beauty. Look at all this deduping, it's amazing!

But this was absolutely a joint effort despite what @DeeDeeG says, they are just being modest lol.

But yes lets get this in before our next release!

@confused-Techie confused-Techie merged commit ccaf920 into master Nov 15, 2023
99 checks passed
@mauricioszabo mauricioszabo deleted the update-github-for-dugite-deduping-reasons branch November 15, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants