-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cirrus: Various fixes for macOS Cirrus CI #961
Conversation
- Pin the base (CI-provided) OS image to Ventura, not Sonoma - Fixes some C/C++ compilation errors?? - Gives us older XCode & compiler toolchain, I guess? - Get node using tj/n utility, not Homebrew - Homebrew "node" package is conflicting with (now deprecated) "node@16" package, loading dynamic libraries like icu4c keeps breaking... - Get Yarn using npm global install, not from Homebrew - I... honestly don't even know at this point. But Yarn from Homebrew is breaking somehow, possibly due to it referring back to Homebrew "node" package, but _that's just a guess_. It's cursed, I guess. - Get python-setuptools from Homebrew, not from pip - Why? Why is this necessary? Homebrew, explain? Something about our "environment being externally managed", so global package installs with pip aren't allowed. This makes sense to someone. See PEP 668. - Adjust PATH exports now that there's no "node@16" from Homebrew
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me and contains no obvious errors. Soft approve!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the patience needed to get this all fixed is very impressive, it is somewhat absolutely ridiculous this much could break in a month in a CI environment.
But anyways super impressed, lets get this all merged, fantastic work!
It sure is! Wasn't expecting that! |
Thank you both for the reviews, I'm spending a moment for some last minute re-reading of my PR body to make sure I've documented this anomalous amount of needed fixes, then intending to merge soon. Thanks! |
PR body seems fine to me. And the last Merging! |
Context / Issues / Timeline
Our Cirrus CI has been on the fritz for the past month-ish.
Changes / Fixes
Verification
These changes (plus tweaks to the
only_if:
directive so the changes would actually run) passed here!: https://cirrus-ci.com/build/4775018807164928Old commits from my experiments are still hosted here if anyone is curious what I tried in order to get here... DeeDeeG/pulsar@master...cirrus-macOS-fixes-old