Fix aws-ts-containers compilation #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍹 The Update for moolumi/k8s-ci-cluster/3fc32749bdfe4a041bab3d0f7cb9ab18cd20c61a-1504 was successful. Resource Changes Name Type Operation
+ multicloud pulumi-kubernetes:ci:GkeCluster create
+ password random:index/randomPassword:RandomPassword create
+ ephemeral-ci-cluster gcp:container/cluster:Cluster create
+ primary-node-pool gcp:container/nodePool:NodePool create
+ gke pulumi:providers:kubernetes create
+ k8s-ci-cluster-3fc32749bdfe4a041bab3d0f7cb9ab18cd20c61a-1504 pulumi:pulumi:Stack create
|
|
We've broken examples a few times recently when updating providers; We should probably be building examples when making providers releases? Alternatively, should the examples versions be pinned somehow and updated after the release goes out? |
|
🍹 The Destroy for moolumi/k8s-ci-cluster/3fc32749bdfe4a041bab3d0f7cb9ab18cd20c61a-1504 was successful. Resource Changes Name Type Operation
- gke pulumi:providers:kubernetes delete
- primary-node-pool gcp:container/nodePool:NodePool delete
- ephemeral-ci-cluster gcp:container/cluster:Cluster delete
- password random:index/randomPassword:RandomPassword delete
|
mjeffryes
approved these changes
Aug 28, 2023
Well it's a possibility; it's going to be a draw on compute time but can help maintain this repo for sure. The check failures are present on master independently yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that "name" property is required. This currently causes CI failure to compile typescript for this example.
https://github.com/pulumi/pulumi-awsx/blob/master/awsx/schema.json#L1208 is the reference.
pulumi/pulumi-awsx#1069 is the change that made this required.
CC @rquitales @mjeffryes