Remove custom worktreeAllowedChanges #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default option will now work fine here and this option is being removed in pulumi/ci-mgmt#1005
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
This had no effect as publish.goSdk.usePush defaults to true
blampe
approved these changes
Jun 26, 2024
danielrbradley
added a commit
to pulumi/ci-mgmt
that referenced
this pull request
Jun 26, 2024
This is not needed to be overridden now the rollout is complete. Only use of override is also no longer needed: https://github.com/search?q=org%3Apulumi+path%3A.ci-mgmt.yaml+%22worktreeAllowedChanges%3A%22&type=code PR to remove dangling use: pulumi/pulumi-kafka#459
danielrbradley
added a commit
to pulumi/ci-mgmt
that referenced
this pull request
Jun 26, 2024
These are never actually overridden so can be inlined to reduce complexity of possible conditons. Single reference to goSdk was in pulumi-kafka which had no effect. PR to remove: pulumi/pulumi-kafka#459 Stacked on top of: - #1003
|
This PR has been shipped in release v3.7.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publish.goSdkconfig. This had no effect aspublish.goSdk.usePushdefaults to trueWorkflows will be re-generated on next nightly CI upgrade.