Drop python 2.7 #212
Drop python 2.7 #212
Conversation
eric-wieser
force-pushed
the
drop-python-2.7
branch
from
3f66c31 to
004b483
Compare
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
==========================================
- Coverage 70.77% 70.24% -0.54%
==========================================
Files 9 9
Lines 4592 4533 -59
==========================================
- Hits 3250 3184 -66
- Misses 1342 1349 +7
Continue to review full report at Codecov.
|
eric-wieser
force-pushed
the
drop-python-2.7
branch
2 times, most recently
from
9bc7864 to
c9a9f0c
Compare
eric-wieser
force-pushed
the
drop-python-2.7
branch
2 times, most recently
from
d96d65c to
e87bc40
Compare
There is no need to do this now that we have dropped python 2
eric-wieser
force-pushed
the
drop-python-2.7
branch
from
e87bc40 to
33ddee7
Compare
|
@thecodebeat, any idea what's going on with the reported fixed issue count here? |
| @@ -9,12 +9,8 @@ | |||
| PY2 = sys.version_info[0] == 2 | |||
| PY3 = sys.version_info[0] == 3 | |||
There was a problem hiding this comment.
Looks like these two lines (and import sys above) also should be removed — or am I missing something?
There was a problem hiding this comment.
This module is public API, so needs to stick around probably for another release. Imagine a project that works in both 2 and 3, and depends on galgebra.utils. Such a project should keep working in 3 after this change, even though utils isn't doing anything useful any more.
There was a problem hiding this comment.
We could actually drop utils in entirety in a later PR since I'm pretty sure no one would have been using in any serious way after I introduced it.
Fixes #83
There are a lot of places where galgebra can benefit from the keyword-only argument syntax.
If desired, I can split the last commit of this PR to a new PR.